Skip to content

(part 1) no package flags when building cmi files #4744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Conversation

bobzhang
Copy link
Member

@bobzhang bobzhang commented Oct 11, 2020

seems

-bs-package-name graph -bs-ns Graph

The first part is not needed for cmi, the latter is still needed for cmi

rule cmji
  command = $bsc $g_pkg_flg $g_lib_incls $warnings $bsc_flags -o $out $in
  dyndep = $in_e.d
  restat = 1

we should expand g_pkg_flg locally to make use of $in_d which means rules has to take advantage of package info earlier

@bobzhang bobzhang changed the title no package flags when building cmi files (part 1) no package flags when building cmi files Oct 12, 2020
@bobzhang bobzhang merged commit 67af904 into master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant