Skip to content

Logical ops not found in BigInt #7366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 5 tasks
dsiu opened this issue Mar 26, 2025 · 2 comments · Fixed by #7482
Closed
3 of 5 tasks

Logical ops not found in BigInt #7366

dsiu opened this issue Mar 26, 2025 · 2 comments · Fixed by #7482
Assignees
Milestone

Comments

@dsiu
Copy link

dsiu commented Mar 26, 2025

BigInt.land, BigInt.lor, BigInt.xor, BigInt.lsl, BigInt.asr all not found in alpha.10. Worked in alpha.9 and prior.

let t0 = BigInt.land(1n, 0n)

output:

Type Errors
[E] Line 1, column 9:
The value land can't be found in BigInt

Playground

Thank you for filing! Check list:

  • Is it a bug? Usage questions should often be asked in the forum instead.
  • Concise, focused, friendly issue title & description.
  • A minimal, reproducible example.
  • OS and browser versions, if relevant.
  • Is it already fixed in master? Instructions
@cknitt
Copy link
Member

cknitt commented Mar 29, 2025

These were renamed, see #7353.
We probably should have deprecated the old functions instead of removing them. /cc @cometkim

@cometkim
Copy link
Member

Yes, if we don't provide any compat library or module

@cometkim cometkim self-assigned this May 3, 2025
@cknitt cknitt added this to the v12 milestone May 5, 2025
cometkim added a commit to cometkim/rescript that referenced this issue May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants