when doesn't use an interface file ,changes propagate to the parent js file with no content change

[ArcherDs]

compiler version after this patch rescript-lang/syntax#655

[minimal, reproducible example] https://github.com/jihchi/vitejs-template-react-rescript (delete the App.resi file)

Main.res depends on App.res , edit App.res and Main.bs.js will also been write with no content change , result a full page reload , broken the fast refresh

if revert this commmit or add a interface file ( App.resi ) to the edit file , the problem gone

OS : wsl2

[mununki]

It's interesting that the commit you mentioned as the root cause created the issue.
When the type of a dependent module (in this case App.res) changes, recompiling Main.res and rewriting the js file if it doesn't have an interface is the default behavior, even before this commit, and that has nothing to do with JSX ppx.
You can see this by creating a very simple project and experimenting with it. You'll see modifications happening, like adding a type definition to App.res. Changing the definition of a React component rewrites the props type, which creates the same effect.

[ArcherDs]

those opration you mentioned do have the same effect before or after this commit

but before this commit , many opration inside react component function doesn't trigger this effect , for example add classname , edit some text inside jsx

I think in all the case if res and resi file doesn't change the js file can't be changed and there is no need to overwrite the js file ( parent component in the example ) , am i right?

now i use a plugin to bail out these case , but i think less unnecessary change better

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.