Skip to content

Pattern matching JS output bug #4990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bloodyowl opened this issue Mar 9, 2021 · 2 comments · Fixed by benadamstyles/bs-fluture#45 · May be fixed by tomvardasca/rescript-next-linaria-template#29
Closed

Pattern matching JS output bug #4990

bloodyowl opened this issue Mar 9, 2021 · 2 comments · Fixed by benadamstyles/bs-fluture#45 · May be fixed by tomvardasca/rescript-next-linaria-template#29

Comments

@bloodyowl
Copy link
Collaborator

On BS 9:

Seems like the output forgets to negate the result in some cases:

https://rescript-lang.org/try?code=PTAEAUBsFMEMGdqgHYHsAu0BcAoEoBaIvMAFQAskpYBPAcwCdUBXZAE1AEt5R51PIkULFAB3VAwDWXZKAAOTRtHjwSoAErQAygGMGnOelBhUkDpoSpZ8GsnSwAHr3Isz82A0SgAVsz5qAM05kJAAKOlRQdEj0SlAAIi1odH5kOnh49xChAIko1Do6SGC6Xlt7BwBKADoSNQAxaGgchib8+UhaYSZWDlh2UB1UAFs5ASR4Eeg1TV19Q0HUNmgAQhwcdBo5CZdRUABeHFBQAB9QADlUI9PQAEEAzAZQ4PRK67OATWV1mCN4XdIqAAUjx9qBQlUDgA+a7wUScdA6cigJwAb3eoC+PDO90eoQA+pVoVEGMxpsczpdiQFYJBENcAL4-ZIog7OVCiQEg0JYon4Gl06AAGnZzDcACMkOhSdNfqAaGz-hyufBQrjoE8AIyVPlgAWIEVKsUcSUksk4OUAL0VAOBqsuurNwtFEqQ+um6yAA
bobzhang added a commit that referenced this issue Mar 10, 2021
@bobzhang
fix #4990
ceab333
bobzhang added a commit that referenced this issue Mar 10, 2021
@bobzhang
fix #4990
09209fe
bobzhang added a commit that referenced this issue Mar 10, 2021
@bobzhang
Merge pull request #4991 from rescript-lang/fix_4990
f8cc8b4 
fix #4990
@bobzhang
Copy link
Member

fixed in master, we are going to schedule a bug fix release

bobzhang added a commit that referenced this issue Mar 10, 2021
@bobzhang
fix #4990
7bd9255
@gaku-sei gaku-sei mentioned this issue Mar 10, 2021
Merged
@bobzhang
Copy link
Member

@bloodyowl you can test it with 9.0.2

This was referenced Mar 15, 2021
Merged
Open
Closed
anmonteiro referenced this issue in melange-re/melange Mar 19, 2021
@bobzhang @anmonteiro
fix #4990
65169a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bobzhang @bloodyowl