Skip to content

Conversation

@jmagaram
Copy link
Contributor

@jmagaram jmagaram commented Apr 11, 2023

Add unknown to primitive types section and explain what it is. Explain a bit how to use it when binding to external JS functions. Provide a more comprehensive and interesting explanation of the unit type; this really is an important thing and deserves more than "you won't need it until you see it". It took a while for me to try to write this in a friendly and easy-to-understand way. I hope it works for you.

@jmagaram jmagaram changed the title Master Documentation for unknown (and unit) Apr 11, 2023
@cristianoc cristianoc requested a review from ryyppy April 12, 2023 01:44
Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a tiny comment

@cristianoc cristianoc removed the request for review from ryyppy April 12, 2023 03:31
@cristianoc
Copy link
Contributor

Ready to merge.
Thanks for the fix.

@cristianoc cristianoc merged commit cdd0dcc into rescript-lang:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants