Skip to content

Conversation

@cristianoc
Copy link
Contributor

@cristianoc cristianoc requested a review from zth September 27, 2022 07:13
Copy link
Member

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question!

| -------------------- | -------------------------------- |
| `// Line comment` | Same |
| `/* Comment */` | Same |
| `/** Doc Comment */` | `/** Doc Comment Attached */` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth clarifying what "attached" means. It reads like it's different to JS (since it's not marked as "Same" in the ReScript column).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now?

@zth zth self-requested a review September 27, 2022 11:27
@cristianoc cristianoc merged commit 59cd87f into master Sep 27, 2022
@fhammerschmidt fhammerschmidt deleted the doc_comments branch July 30, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants