This repository was archived by the owner on Aug 10, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated bs-mocha
[@bs]
annotations, they seemed to be unnecessary since the bindings worked fine without it (I thinkunit -> unit
works the same curried/uncurried because it's unary)@bobzhang One other thing that I had to do in order to use these bindings is to copy the
bsconfig.json
from thebucklescript-addons/bindings/bs-mocha
folder to my project'snode_modules/bs-mocha
folder. For some reason all files are there when I install bs-mocha (usingnpm install bs-mocha
) except forbsconfig.json
, sobsb
never found it. I don't know what's hiding it, I think this is the only thing left to do