Skip to content
This repository was archived by the owner on Aug 10, 2020. It is now read-only.

Updated bs-mocha #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Risto-Stevcev
Copy link

I updated bs-mocha

  • I updated to the latest version of mocha and bs-platform
  • I added missing definitions to the interface file (those functions otherwise couldn't be reached without it)
  • I removed the [@bs] annotations, they seemed to be unnecessary since the bindings worked fine without it (I think unit -> unit works the same curried/uncurried because it's unary)

@bobzhang One other thing that I had to do in order to use these bindings is to copy the bsconfig.json from the bucklescript-addons/bindings/bs-mocha folder to my project's node_modules/bs-mocha folder. For some reason all files are there when I install bs-mocha (using npm install bs-mocha) except for bsconfig.json, so bsb never found it. I don't know what's hiding it, I think this is the only thing left to do

@bobzhang
Copy link
Member

bobzhang commented Dec 20, 2017

@Risto-Stevcev would you take it over to move it to https://github.com/reasonml-community/ ?

@Risto-Stevcev
Copy link
Author

@bobzhang Sure, I'm not sure how to take it over and move it there though. I'm not a member

@glennsl
Copy link
Contributor

glennsl commented Jan 22, 2018

@Risto-Stevcev I've created https://github.com/reasonml-community/bs-mocha and made you an admin on it. Let me know if you need help moving the code there.

@bobzhang Can you give Risto publishing rights for bs-mocha on npm?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants