Skip to content

Python <-> Rust bridge fixes #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 19, 2022
Merged

Python <-> Rust bridge fixes #42

merged 3 commits into from
Aug 19, 2022

Conversation

nikolausWest
Copy link
Member

  • Fixes so that we can log point clouds without colors from the Python SDK
  • Fixes so that we copy numpy views before passing to Rust also for log_points (before it was just for log_tensor)

@nikolausWest nikolausWest requested a review from emilk August 19, 2022 15:08
@nikolausWest nikolausWest changed the title Python rust bridge fixes Python <-> Rust bridge fixes Aug 19, 2022
@emilk emilk merged commit ac5f348 into main Aug 19, 2022
@emilk emilk deleted the python-rust-bridge-fixes branch August 19, 2022 21:00
teh-cmc added a commit that referenced this pull request Sep 22, 2023
@teh-cmc
Enforce TODO formatting (#3404)
5acb22b 
A trivial PR to enforce the formatting of TODOs.

This is groundwork for an upcoming PR that checks for zombie TODOs on CI
(TODOs that reference an issue that is already fixed).

TL;DR: these are legal, everything else is not (hopefully):
- `TODO(bob)`
- `TODO(bob, alice)`
- `TODO(#42)`
- `TODO(#42, #43)`
- `TODO(rust-lang/rust#42)`
- `TODO(rust-lang/rust#42, rust-lang/rust#43)`
@teh-cmc teh-cmc mentioned this pull request Jan 30, 2024
Closed
4 tasks
emilk added a commit that referenced this pull request Apr 3, 2025
@emilk @Wumpf
Support #datapath fragment on redap URL (#9478)
bc9281d 
This adds support for appending a data path (e.g. `/some/entity[#42]`)
to a redap URL, as a `#fragment`.

When clicking a redap URI with such a fragment, we will focus on that
entity.
This is untested, however, and depends on us keeping the focus until the
entity is loaded.

A `DataPath` is currently defined as

```rs
pub struct DataPath {
    pub entity_path: EntityPath,
    pub instance: Option<Instance>,
    pub component_name: Option<ComponentName>,
}
```

We will wanna extend this in the future to support tagging, and maybe
even a timepoint.

### Extending it with time point

It's not clear how to specify _both_ time _and_ a data path in the
fragment 🤔 I guess we need to use a special character, like comma:

`#/entity/path,log_tick=42` maybe

…and then comes the trouble of escaping

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikolausWest @emilk