-
Couldn't load subscription status.
- Fork 554
Fix building Web Viewer on macOS #10828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Thanks for working on this! I'll give it a spin |
|
I tested this by first running Checking out this branch and running I do have Looks like Just removing ->
|
|
UGH I thought I tested it when I changed from
|
|
That got us to a new place! |
Umm $ cargo --version
cargo 1.87.0 (99624be96 2025-05-06)
$ rustup --version
rustup 1.28.2 (e4f3ad6f8 2025-04-28)
$ rustc --version
rustc 1.87.0 (17067e9ac 2025-05-09)
$ clang --version
clang --version
Apple clang version 17.0.0 (clang-1700.0.13.5)
Target: arm64-apple-darwin24.5.0
Thread model: posixcommands $ rm -rf target_wasm/
$ rm -rf target/ # for fun
$ pixi run rerun-build-web
...snip
Finished /Users/nick/repos/rerun/web_viewer/re_viewer_bg.wasm |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo!
should we setup a test for the web build on mac just for this weird edge case? |
We already do, but not on every PR, unless we explicitly opt-in to the full test suite with |
### Related Closes #9849 ### What Basically mac has a fun combination where you can have `clang`/`llvm` components but not `llvm-ar`. Mac's `ar` pads bytes in way that make llvm barf. Our pixi env for c++ has the `cxx-compiler` package which has a more full fledged llvm install. On mac on activation set `AR` to point to `llvm-ar`. It works on my machine! I'm not sure if we should have a second person try or if we should setup a test for the web build on mac just for this weird edge case.
Related
Closes #9849
What
Basically mac has a fun combination where you can have
clang/llvmcomponents but notllvm-ar. Mac'sarpads bytes in way that make llvm barf. Our pixi env for c++ has thecxx-compilerpackage which has a more full fledged llvm install. On mac on activation setARto point tollvm-ar. It works on my machine! I'm not sure if we should have a second person try or if we should setup a test for the web build on mac just for this weird edge case.