feat(v3): use values and optionalValues from HelmChart custom resource when installing app charts #2719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
previously approved these changes
Aug 22, 2025
…e when installing app charts
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sgalsaleh
force-pushed
the
salah/sc-128065/make-sure-the-values-and-optionalvalues-fields
branch
from
bb94c9a to
1effd0b
Compare
emosbaugh
approved these changes
Aug 22, 2025
|
Merging as failing tests are irrelevant. |
sgalsaleh
deleted the
salah/sc-128065/make-sure-the-values-and-optionalvalues-fields
branch
diamonwiggins
added a commit
that referenced
this pull request
Aug 25, 2025
* Revert "feat(v3): pass isEmbeddedClusterV3 to adminconsole chart (#2723)" This reverts commit 58fb99e. * Revert "Extract installable charts test improvements (#2722)" This reverts commit 6aee665. * Revert "feat(v3): use values and optionalValues from HelmChart custom resource when installing app charts (#2719)" This reverts commit ed1fceb. * Revert "feat(v3): install Helm charts directly without KOTS CLI (#2715)" This reverts commit 9f1cb9f.
emosbaugh
pushed a commit
that referenced
this pull request
Aug 27, 2025
…e when installing app charts (#2719) * feat(v3): use values and optionalValues from HelmChart custom resource when installing app charts * fix tests * fix conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
use values and optionalValues from HelmChart custom resource when installing app charts
Which issue(s) this PR fixes:
SC-128065
Does this PR require a test?
Yes
Does this PR require a release note?
Does this PR require documentation?
NONE