Skip to content

Fix Pydantic validation errors for Training responses #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 3 commits into from
Apr 12, 2023
Merged

Fix Pydantic validation errors for Training responses #90

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80d84b2
Relax Training version type constraint to be Optional
mattt Apr 12, 2023
c528ee4
Delete version field from JSON response in trainnings.get
mattt Apr 12, 2023
7744155
Remove version field from trainings.create response
mattt Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion replicate/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from replicate.exceptions import ReplicateException
from replicate.files import upload_file
from replicate.json import encode_json
from replicate.version import Version


class Training(BaseModel):
Expand All @@ -19,7 +20,7 @@ class Training(BaseModel):
output: Optional[Any]
started_at: Optional[str]
status: str
version: str
version: Optional[Version]

def cancel(self) -> None:
"""Cancel a running training"""
Expand All @@ -44,6 +45,8 @@ def get(self, id: str) -> Training:
f"/v1/trainings/{id}",
)
obj = resp.json()
# HACK: resolve this? make it lazy somehow?
del obj["version"]
return self.prepare_model(obj)

def create( # type: ignore
Expand Down Expand Up @@ -83,4 +86,5 @@ def create( # type: ignore
json=body,
)
obj = resp.json()
del obj["version"]
return self.prepare_model(obj)