-
Notifications
You must be signed in to change notification settings - Fork 256
Add async support #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add async support #193
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
790a8db
Change Prediction and Training version field to be a string
mattt 91ea8ba
Simplify signature of _prepare_model
mattt 9104bb5
Remove _prepare_model definition from Collection
mattt b6acc87
Remove _models and __init__ definition from Collections
mattt 6035615
Inline _client property and _prepare_model logic into individual cla…
mattt 5a4e309
Remove generic type and model field from Namespace
mattt e55ab99
Refactor common deserialization code into helper methods
mattt d8dbd64
Add async support
mattt a2fcb95
Configure mypy to enable Unpack
mattt 2e66a97
Fix Training create overloads
mattt 05efc4e
Extract prediction creation parameters into CreatePredictionParams
mattt 41bc305
Adopt unpacked prediction params in deployments
mattt 7454052
Continue refactoring create and params
mattt 5dd5c96
Implement async run
mattt 1a59da2
Test predictions.create with positional arguments
mattt 68ed421
Create Models.CreateModelParams type
mattt 8ce6e13
Remove unnecessary pylint ignores
mattt 6f629fb
Add example of how to run several predictions concurrently
mattt 9eb8d3a
Skip test_run_concurrently if running on Python < 3.11
mattt b2d081d
Update README
mattt 0a7d2c1
Set client poll interval in tests conditionally
mattt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
good-namesmean?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're good names, Zeke.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(But seriously, this is to stop pylint from complaining about variables named
id)