Use recorded sessions instead of mocking for tests #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattt Zmuda <[email protected]>
Signed-off-by: Mattt Zmuda <[email protected]>
Signed-off-by: Mattt Zmuda <[email protected]>
Signed-off-by: Mattt Zmuda <[email protected]>
Signed-off-by: Mattt Zmuda <[email protected]>
Signed-off-by: Mattt Zmuda <[email protected]>
Contributor
Author
|
Tests are passing for Python 3.10+. Unfortunately, vcrpy blocks installation of urllib3 v2 for Python < 3.10. I'm keen to replace requests for httpx, which doesn't have this dependency on urllib3, so I'm closing this PR in favor of making that change together. |
Contributor
Author
|
See #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces responses with pytest-recording and updates tests to run against recordings of real network traffic instead of mocked responses.