Run unit tests with TypeScript #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline option types Fix method signatures Define Page<T> type
Fix and refactor unit tests
erbridge
reviewed
Apr 5, 2023
Contributor
erbridge
left a comment
erbridge
left a comment
There was a problem hiding this comment.
I've not reviewed this thoroughly, but in principle it seems like a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently have test coverage for our TypeScript definitions, which means that we won't notice if something's broken until we try to use the library in a TypeScript project.
This PR updates our unit tests to run with ts-jest, and fixes all of the problems in our type definitions that surfaced.