Fix passing abort signal into run method #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents it being passed to the backend as part of the body. The backend has recently started validating the body payload so this is now resulting as an API error. Fixes #249
Previously when aborting a `run()` request we were dropping the final canceled prediction object and calling the `onProgress` callback with a stale "processing" object.
erbridge
approved these changes
May 2, 2024
Contributor
|
Nice. Thanks, @aron! Cutting a new patch release with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with passing the
AbortControlleras asignaloption to thereplicate.run()method.Firstly now extract the
signalproperty from therun()options and do not pass on as part of the API body. The backend has recently started validating the body payload so this is now resulting as an API error. This fixes the issue reported in #249.Secondly, we now call the
onProgresshandler with the terminal canceled prediction. Previously when aborting arun()request we were dropping the final canceled prediction object and calling theonProgresscallback with a stale "processing" object.I've updated the tests to verify both of these changes.