Skip to content

Conversation

@mattt
Copy link
Contributor

@mattt mattt commented Mar 18, 2024

Follow-up to #220

At @aron's suggestion, I tried using replicate.stream for the Bun integration test. However, that failed because Bun doesn't currently support TextDecoderStream (oven-sh/bun#5648).

As a workaround, this PR vendors @stardazed/streams-text-encoding (with modifications), and adds a conditional polyfill.

@mattt mattt marked this pull request as ready for review March 18, 2024 12:12
@mattt mattt requested a review from aron March 18, 2024 12:12
@mattt mattt requested a review from aron March 18, 2024 13:41
Copy link
Contributor

@aron aron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mattt mattt merged commit f280b0b into main Mar 19, 2024
@mattt mattt deleted the mattt/bun-streaming branch March 19, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants