Automatically Base64 encode inputs #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aron Carroll <[email protected]>
mattt
force-pushed
the
base64-encode-inputs
branch
from
e886539 to
6945c23
Compare
Contributor
|
@aron That's a great idea. Thanks for putting this together! Even when we do have a files API, it would be nice to configure a client to still pass data URIs. For example, when setting a custom base URL or automatically falling back if the files API isn't available. |
mattt
approved these changes
Feb 17, 2024
Member
|
Hot damn. That's a nice quality of life improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this here as it's been sitting on my hard-drive for over a week.
@mattt I think it's probably worth supporting auto-upload to the files endpoint too before we ship this, but curious as to your thoughts.