Fix fetch scoping for cloudflare workers #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
reviewed
Oct 9, 2023
mattt
approved these changes
Oct 9, 2023
Contributor
mattt
left a comment
mattt
left a comment
There was a problem hiding this comment.
@robertlong Thanks so much for sharing this fix! I'm also confused about why this is necessary. "Cloudflare Workers uses the V8 JavaScript engine", but something in their runtime seems to cause JavaScript context to behave differently.
Whatever the reason, I'm happy the fix you've found is small and unlikely to cause issues with other environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having the same bug described in #134 and traced it to this line.
Still trying to wrap my head around why
this.fetchcannot be invoked when the wrapping closure is called insidewithAutomaticRetries. And why does this only happen in cloudflare workers? Saving the fetch method to a temporary variable seems to work though.Fixes #134