-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
fix: empty dataResults causes "no corresponding fetcher result" #14062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hi @ZxBing0066, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Can we add a test for this? Preventing regression is really important in cases like this. |
@timdorr Test added. Please help review. |
The failed test seems to be a flaky one. I also see it in other PR. |
When requests are aborted, it should always return a valid dataResults; otherwise,
processLoaderData
throws the"Did not find corresponding fetcher result"
error.Introduced by this PR.
fixes #13712