Skip to content

fix(package): upgrade html-dom-parser to fix client ES Module export #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

remarkablemark
Copy link
Owner

What is the motivation for this pull request?

fix(package): upgrade html-dom-parser to fix client ES Module export

See remarkablemark/html-dom-parser#335

What is the current behavior?

ReferenceError: module is not defined

What is the new behavior?

No ReferenceError

Checklist:

@remarkablemark remarkablemark added bug Something isn't working dependencies Pull requests that update a dependency file labels Aug 20, 2022
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 10.23 KB (+0.23% 🔺) 205 ms (+0.23% 🔺) 74 ms (+12.93% 🔺) 279 ms

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #663 (415cb59) into master (b79658d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          167       167           
  Branches        57        57           
=========================================
  Hits           167       167           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@remarkablemark remarkablemark merged commit 42fe77e into master Aug 20, 2022
@remarkablemark remarkablemark deleted the fix/html-dom-parser branch August 20, 2022 02:53
@remarkablemark
Copy link
Owner Author

Release #664 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants