Skip to content

fix(client): correct ECMAScript export in client html-to-dom.mjs #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2022

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Aug 20, 2022

What is the motivation for this pull request?

fix(client): correct ECMAScript export in client html-to-dom.mjs

Fixes #334

What is the current behavior?

ReferenceError: module is not defined

What is the new behavior?

No ReferenceError

Checklist:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-dom-parser.min.js 3.8 KB (+0.52% 🔺) 76 ms (+0.52% 🔺) 70 ms (+12.96% 🔺) 146 ms

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #335 (d61f10b) into master (848a622) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
+ Coverage   94.28%   94.32%   +0.04%     
==========================================
  Files           7        7              
  Lines         140      141       +1     
==========================================
+ Hits          132      133       +1     
  Misses          8        8              
Impacted Files Coverage Δ
lib/client/domparser.js 85.96% <100.00%> (+0.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@remarkablemark remarkablemark merged commit c9339d7 into master Aug 20, 2022
@remarkablemark remarkablemark deleted the fix/mjs branch August 20, 2022 02:40
@remarkablemark
Copy link
Owner Author

Release #336 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib/client/html-to-dom.mjs is not a valid ECMAScript Module
2 participants