Skip to content

fix(index): refactor ES module from ES6 to ES5 syntax #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Feb 1, 2021

Fixes #222

What is the motivation for this pull request?

fix(index): refactor ES module from ES6 to ES5 syntax

This is a regression from #220

What is the current behavior?

The ES module index.mjs uses ES6 syntax (object destructuring assignment), which breaks older browsers like IE11.

What is the new behavior?

index.mjs uses ES6 syntax.

Fixes #222

Do not use object destructuring assignment in `index.mjs` since
it's not supported by older browsers like Internet Explorer 11.
@remarkablemark remarkablemark added the bug Something isn't working label Feb 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 7.23 KB (0%) 145 ms (0%) 86 ms (-7.25% 🔽) 231 ms

@remarkablemark remarkablemark merged commit 8c69887 into master Feb 1, 2021
@remarkablemark remarkablemark deleted the fix/es-module branch February 1, 2021 00:32
@remarkablemark
Copy link
Owner Author

Published v1.2.4:

npm:

Yarn:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will Internet Exporer 11 be supported?
1 participant