Skip to content

Conversation

@keigohtr
Copy link
Member

@keigohtr keigohtr commented May 8, 2019

What is this PR for?

Add GCS support.

This PR includes

  • Add GcsHandler
  • Add test

What type of PR is it?

Feature

What is the issue?

#30

How should this be tested?

Run unittest

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keigohtr keigohtr merged commit 7a186ee into master May 16, 2019
@keigohtr keigohtr deleted the feature/gcs-support branch May 16, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants