Pass object to update predictor

[keigohtr]

What is this PR for?

When we switch model, it does not work.
This is because the current code updates a local variable. So I changed to use a list object to update predictor object.

This PR includes

• Use list as input

What type of PR is it?

Bugfix

What is the issue?

N/A

How should this be tested?

$ python -m unittest

[yuki-mt]

@keigohtr
I figured out what is wrong, but this solution (and current situation) has very implicit dependency between RekcurdDashboardServicer and RekcurdWorkerServicer, which may make it difficult to read the code.

What about adding setter of predictor to RekcurdWorkerServicer and call it in RekcurdDashboardServicer?

[keigohtr]

@yuki-mt
Thank you for your review.
Hummmm... I think having an implicit dependency between RekcurdDashboardServicer and RekcurdWorkerServicer is natural for this case since we need to share predictor during the application.

And, adding one servicer to another is weird for me since it seems they are parent-child relationship. Using a pointer and sharing variables is not strange implementation I think.

But we can create a class and use it instead of list is a good idea I think.
How do you think?

[yuki-mt]

adding one servicer to another is weird for me since it seems they are parent-child relationship.

DashbaordServicer affects WorkerServicer in fact, so this is not weird to me, but

I think having an implicit dependency between RekcurdDashboardServicer and RekcurdWorkerServicer is natural for this case since we need to share predictor during the application.

I agree with it.

But we can create a class and use it instead of list is a good idea I think.

I also agree with it. It looks better.

[keigohtr]

@yuki-mt I have updated. Could you review this again please?

[codecov-io]

Codecov Report

Merging #43 into master will increase coverage by <.01%.
The diff coverage is 98.33%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   88.05%   88.06%   +<.01%     
==========================================
  Files          15       15              
  Lines         854      863       +9     
==========================================
+ Hits          752      760       +8     
- Misses        102      103       +1

Impacted Files	Coverage Δ
rekcurd/core/__init__.py	100% <100%> (ø)	⬆️
rekcurd/core/rekcurd_worker_servicer.py	87.03% <100%> (-0.08%)	⬇️
rekcurd/core/rekcurd_dashboard_servicer.py	97.29% <100%> (+0.12%)	⬆️
rekcurd/core/rekcurd_worker.py	76.47% <80%> (+0.18%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5795490...a5a342f. Read the comment docs.

[yuki-mt]

LGTM