Skip to content

Conversation

@keigohtr
Copy link
Member

What is this PR for?

Add error log output

This PR includes

  • Add output error log

What type of PR is it?

Feature

What is the issue?

N/A

How should this be tested?

N/A

@keigohtr keigohtr self-assigned this Feb 28, 2019
@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #42 into master will decrease coverage by 0.24%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   88.29%   88.05%   -0.25%     
==========================================
  Files          15       15              
  Lines         846      854       +8     
==========================================
+ Hits          747      752       +5     
- Misses         99      102       +3
Impacted Files Coverage Δ
rekcurd/core/rekcurd_worker.py 76.28% <100%> (+0.75%) ⬆️
rekcurd/core/rekcurd_worker_servicer.py 87.11% <71.42%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd8d73b...e5a3003. Read the comment docs.

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keigohtr keigohtr merged commit 4fea0fd into master Feb 28, 2019
@keigohtr keigohtr deleted the fix/output-error-log branch February 28, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants