Skip to content

Conversation

@keigohtr
Copy link
Member

What is this PR for?

For dashboard renewal, we don't use SERVICE_NAME anymore.

This PR includes

  • Use SERVICE_ID instead SERVICE_NAME

What type of PR is it?

Fix

What is the issue?

N/A

How should this be tested?

$ python -m unittest

@keigohtr keigohtr self-assigned this Feb 25, 2019
@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #39 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   88.05%   88.31%   +0.26%     
==========================================
  Files          15       15              
  Lines         854      839      -15     
==========================================
- Hits          752      741      -11     
+ Misses        102       98       -4
Impacted Files Coverage Δ
rekcurd/core/rekcurd_dashboard_servicer.py 97.16% <ø> (ø) ⬆️
rekcurd/utils/rekcurd_config.py 83.18% <100%> (-0.72%) ⬇️
rekcurd/core/rekcurd_worker.py 76.08% <0%> (-0.21%) ⬇️
rekcurd/core/rekcurd_worker_servicer.py 88.6% <0%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fea0fd...077808c. Read the comment docs.

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you need to resolve conflict

@keigohtr
Copy link
Member Author

@yuki-mt Thank you for your review.
I have solved conflict! Could you review this again please?

@keigohtr keigohtr merged commit 5795490 into master Feb 28, 2019
@keigohtr keigohtr deleted the fix/use_service_id branch February 28, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants