Add template generation script #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keigohtr
requested review from
jkw552403,
shimpei-yotsukura,
sugyan,
yoquankara,
yuki-mt and
yustoris
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 91.3% 89.12% -2.19%
==========================================
Files 14 14
Lines 794 809 +15
==========================================
- Hits 725 721 -4
- Misses 69 88 +19
Continue to review full report at Codecov.
|
yuki-mt
reviewed
Feb 21, 2019
Member
yuki-mt
left a comment
yuki-mt
left a comment
There was a problem hiding this comment.
made one trivial comment, but basically LGTM!
yuki-mt
approved these changes
Feb 21, 2019
Member
Author
|
@yuki-mt Thank you reviewing! |
yuki-mt
reviewed
Feb 21, 2019
| self.APPLICATION_NAME = os.getenv("REKCURD_APPLICATION_NAME") | ||
| self.SERVICE_NAME = os.getenv("REKCURD_SERVICE_NAME") | ||
| self.SERVICE_PORT = int(os.getenv("REKCURD_SERVICE_PORT", "5000")) | ||
| self.SERVICE_PORT = int(os.getenv("REKCURD_SERVICE_PORT", "{}".format(self.__SERVICE_DEFAULT_PORT))) |
Member
There was a problem hiding this comment.
I forgot this one also can be str(self. __SERVICE_DEFAULT_PORT) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add
rekcurdcommand line script to generateRekcurdapplication template.This PR includes
dummy_app.pyand usetemplate/app.py-tplfor the unittestingWhat type of PR is it?
Feature
What is the issue?
N/A
How should this be tested?