-
Notifications
You must be signed in to change notification settings - Fork 9
Introduce inputModes option for showing score and comment fields #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Introduce inputModes option for showing score and comment fields #472
Conversation
…n-score-when-asking-for
…n-score-when-asking-for
…n-score-when-asking-for
…n-asking-for' of https://github.com/bucketco/bucket-javascript-sdk into buc-3227-dogfooding-dont-require-satisfaction-score-when-asking-for
| position, | ||
| translations = DEFAULT_TRANSLATIONS, | ||
| openWithCommentVisible = false, | ||
| inputMode = "comment-and-score", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about the background here. My thinking is that if someone submits a comment, we'll eventually be able to deduct the sentiment. So it ends up feeling weird to ever have the comment first and then the satisfaction second? I could imagine the options being:
- comment only
- satisfaction + comment shows up (default today)
- satisfaction + comment visible (default today)
I know this is late feedback, apologies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inspiration was Vercel (from the Linear issue):
@makwarth: Here's how Vercel does it, which is the way to do it, imo:
I'm curious about the background here. My thinking is that if someone submits a comment, we'll eventually be able to deduct the sentiment. So it ends up feeling weird to ever have the comment first and then the satisfaction second
Wouldn't that be an argument for the opposite? Why have the score first if it can be derived from the comment?
There can also be a value in specifying the score manually like Vercel; either to be clear about intent or if you don't have time to write a comment but still want to give a nod up/down.
satisfaction + comment shows up
In general, we're moving away from a primary satisfaction score towards it being additional/optional. Having two out of three options put score front and center is misleading and not useful IMO.
I don't see much use for the sequential screens anymore and it complicates implementation a lot. IF you're looking to gather a score for a bigger audience (like post GA release), I think a score-only UI is fine? For all other cases, the comment field is preferred
roncohen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK lets get this in. And let make sure we cut a new major for all the necessary SDKs.
|
and needs a note about breaking changes in the README. |

This PR introduces a new
inputModeoption to the Reflag feedback UI that allows developers to control which input fields are shown to users when collecting feedback. This addresses the need for more flexible feedback collection scenarios where satisfaction scores may not always be required.Changes
Core Feature:
inputModeOptioninputModeparameter with three options:"comment-and-score"(default) - Shows both comment field and satisfaction score"comment-only"- Shows only the comment field, no satisfaction score required"score-only"- Shows only the satisfaction score, no comment fieldAPI Changes
RequestFeedbackOptionsto include the newinputModeparameterFeedbackSubmissioninterface - bothscoreandcommentare now optionalonScoreSubmitwith unifiedonSubmitthat returnsOnSubmitResultrequireSatisfactionScore(replaced byinputMode)openWithCommentVisible(replaced byinputMode)UI/UX Improvements
inputModeDocumentation Updates
inputModeoption.Preview FEEDBACK.md
Preview README.md
Technical Improvements
inputModeparameter with clear error messagesUse Cases
This change enables several new feedback collection scenarios:
Breaking Changes
requireSatisfactionScoreandopenWithCommentVisibleoptions have been removedonScoreSubmitcallback has been replaced with unifiedonSubmitcallbackFeedbackScoreSubmissioninterface has been removedMigration Guide
Before:
After:
Testing
inputModeparameter