Update part-6-performance-normalization.md #4418
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line 480 the original filter function returned an array notifications where !notification.read was the condition. Due to the second render of the NotificationList component allNotificationsRead is being called in useLayoutEffect and notifications.filter(notification=>!notification.read).length becomes 0. So we should return a notifications array from the filter function with the condition notifications.isNew.
name: 🐛 Bug fix or new feature
about: Fixing a problem with Redux
PR Type
Does this PR add a new feature, or fix a bug?
Why should this PR be included?
Checklist
New Features
What new capabilities does this PR add?
What docs changes are needed to explain this?
Bug Fixes
What is the current behavior, and the steps to reproduce the issue?
What is the expected behavior?
How does this PR fix the problem?