Added ES6 scope and error log #1574
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 3, 2016 08:34
Added let to for loop scopes and an additional error log if user decides to do something tricky
Fixed awkward typo mistake
| @@ -73,7 +73,10 @@ export default function createStore(reducer, initialState, enhancer) { | |||
| function getState() { | |||
| return currentState | |||
| } | |||
|
|
|||
|
|
|||
| if (typeof getState !== 'function' || getState == 'undefined') { | |||
There was a problem hiding this comment.
getState is a locally defined function. It is guaranteed to be a function by the code unless I’m missing something.
|
I’m up for replacing |
|
Yeah, did that at first, but considering some variables were used across scopes, I left them as variables, but Mateusz covers this smoothly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added local scoping from ES6 syntax with const to static variables. Also added error log to getState function to notify if the user decides to do something tricky.