Skip to content

[WIP] refactor to eslint airbnb, remove babel-eslint #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[WIP] refactor to eslint airbnb, remove babel-eslint #1559

wants to merge 5 commits into from

Conversation

knowbody
Copy link
Contributor

This is a work in progress on moving to eslint-config-airbnb and removing babel-eslint

Todo

  • - remove babel-eslint
  • - remove eslint-config-rackt
  • - add eslint-config-airbnb
  • - fix the linting according to airbnb style guide
  • - merge awaitng PRs (as per: Stop using babel-eslint #1554 (comment)), and apply new eslint config to them
  • - apply new linting to the docs

@gaearon let me know if you have any feedback on this

@knowbody knowbody mentioned this pull request Mar 31, 2016
Closed
@johnsoftek
Copy link
Contributor

:( It was refreshing to find a project that eschewed semicolon, a la JS
Standard.

Maybe it's too late but why airbnb?

Sent from my phone
On Mar 31, 2016 10:36 AM, "Mateusz Zatorski" [email protected]
wrote:

This is a work in progress on moving to eslint-config-airbnb and removing
babel-eslint
Todo

You can view, comment on, or merge this pull request online at:

#1559
Commit Summary

  • [WIP] refactor to eslint airbnb, remove babel-eslint

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1559

@knowbody
Copy link
Contributor Author

@johnsoftek it's not too late, it's a work in progress. There was a discussion about semicolons somewhere, for me it seriously does not matter. I want on one project with semicolons - I'm fine, working on the other one without them - I'm fine too.

but why airbnb?

airbnb is the most used eslint config and most developers are familiar with it. re: semicolons we can also customise the rules and switch it off, but I don't think we should do it.

@knowbody
Copy link
Contributor Author

@gaearon it ✅ passes the tests. I will update the docs soon, ping me once the PRs you wanted to merge before this, are merged and I'll update this branch with master so we can merge it in.

@gaearon gaearon mentioned this pull request Apr 4, 2016
Closed
@gaearon gaearon mentioned this pull request Apr 14, 2016
Closed
@gaearon gaearon mentioned this pull request May 23, 2016
Merged
@SimenB
Copy link
Contributor

SimenB commented Aug 17, 2016

Anything happening here?

@gaearon
Copy link
Contributor

gaearon commented Aug 17, 2016

There's going to be some churn in examples (see my PR adding CRA). When that's done we can take another look at this.

@timdorr
Copy link
Member

timdorr commented Sep 4, 2016

@knowbody I'm going to do what I did in reduxjs/react-redux#461 to update the config without causing so much churn (mainly to do with semicolons). Unfortunately, in projects as busy as these ones, merging in a PR with huge changes (or dealing with PRs after a huge change) is nearly impossible. So, I found that was a good compromise to keep the process sane. I hope to get to that soon!

@timdorr timdorr closed this Sep 4, 2016
@timdorr timdorr deleted the refactor-lint branch September 4, 2016 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@knowbody @johnsoftek @SimenB @gaearon @timdorr