-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix codegen-openapi tests #4307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 91aea9a:
|
e12e592 to
1bc2b72
Compare
abbeed1 to
b493d3e
Compare
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
5fec656 to
0f1b03f
Compare
|
@aryaemami59 fyi the "ts/json/etc should be the same" test seems to be flaky - sometimes it can't find |
|
Yup that's exactly what it is. I'll have to look into it later. |
Overview
Previously the codegen tests would create side effects which made them unpredictable and caused them to produce inconsistent results. This PR mainly focuses on making the unit tests reliable both during local development and CI.
This PR:
clicommand incli.test.tswith a promisified version of Node'sexecwhich mimicks the actual cli behavior more closely.tsconfigsetup to have atsconfig.build.jsonandtsconfig.jsonas opposed to atest/tsconfig.jsonwithbaseUrl.libfolder during CI.vite-tsconfig-pathswas added todevDependenciesto manage this easier.