rtk-query-codegen-openapi: use patched oazapfts for intersection type gen #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msutkowski
commented
Feb 5, 2022
Comment on lines
+472
to
+474
| export type Dog = Animal & { | ||
| dogUniqueProp?: string | null; | ||
| }; |
There was a problem hiding this comment.
Currently, we don't generate this intersection and only do export type Dog = Animal.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e804687:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
size-limit report 📦
|
|
Could you publish that as a scoped package to npm? I'm not comfortable adding a dependency directly from github. |
|
ping - could you please take a look if this is still not upstream and publish that package? |
msutkowski
force-pushed
the
codegen-use-patched-oazapfts
branch
from
b1478e3 to
e804687
Compare
msutkowski
added a commit
that referenced
this pull request
Jul 3, 2022
… gen (#2004) * Add test for intersection types, reference github commit for patched oazapfts * Use @rtk-query/oazapfts-patched and updated refs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened a PR over in oazapfts here: oazapfts/oazapfts#207. I'd prefer to not be blocked on them merging that PR or a similar one that is referenced in the linked PR. So this would allow us to patch this behavior for our users in the short term.Update
This now uses a patched version of oazapfts (@rtk-query/oazapfts-patched) located at https://github.com/rtk-incubator/oazapfts
Fixes #2002 #1940