Skip to content

Fix broken sourcemap output due to bad filename replacement #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markerikson merged 1 commit into from
Nov 26, 2021
Merged

Fix broken sourcemap output due to bad filename replacement #1773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/toolkit/scripts/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ async function bundle(options: BuildOptions & EntryPointOptions) {
const origin = chunk.text
const sourcemap = extractInlineSourcemap(origin)
const result = ts.transpileModule(removeInlineSourceMap(origin), {
fileName: chunk.path.replace(/.js$/, '.ts'),
fileName: chunk.path,
compilerOptions: {
sourceMap: true,
module:
Expand Down Expand Up @@ -253,7 +253,11 @@ async function bundle(options: BuildOptions & EntryPointOptions) {
/**
* since esbuild doesn't support umd, we use rollup to convert esm to umd
*/
async function buildUMD(outputPath: string, prefix: string, globalName: string) {
async function buildUMD(
outputPath: string,
prefix: string,
globalName: string
) {
for (let umdExtension of ['umd', 'umd.min']) {
const input = path.join(outputPath, `${prefix}.${umdExtension}.js`)
const instance = await rollup.rollup({
Expand Down