Add listener resubscribe option and clean up types #1731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
subscribe
option to thelistenerApi
parameter, which just (re)inserts the currentListenerEntry
back into the map. This allows a form oftakeLeading
-style behavior -unsubscribe()
at the start of the listener, do logic,subscribe()
when you're done, so that only one instance is running at a timeaddListenerAction
handling so that it does the same "any other entries with this same listener callback?" check asaddListener