Skip to content

Conversation

@msutkowski
Copy link
Member

@msutkowski msutkowski commented Nov 9, 2021

Fixes #1709.

I believe we can just skip setting this property in the substate when it's undefined. I double-checked all of the invalidation behavior and this appears to be a non-issue.

For a user that uses originalArgs, there is no difference in the check they'd have to use for this anyways?

https://codesandbox.io/s/rtkq-beta-ssr-repro-7q819 - CSB running this build

@msutkowski msutkowski requested a review from phryneas November 9, 2021 03:53
copyWithStructuralSharing,
} from '../utils'
import type { ApiContext } from '../apiTypes'
import { defaultMemoize } from 'reselect'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a 🧟 import.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (cjs.production.min.js) 12.88 KB (0%)
1. entry point: @reduxjs/toolkit (esm.js) 10.76 KB (0%)
1. entry point: @reduxjs/toolkit/query (cjs.production.min.js) 22.51 KB (+0.02% 🔺)
1. entry point: @reduxjs/toolkit/query (esm.js) 18.85 KB (+0.05% 🔺)
1. entry point: @reduxjs/toolkit/query/react (cjs.production.min.js) 24.64 KB (+0.02% 🔺)
1. entry point: @reduxjs/toolkit/query/react (esm.js) 21.4 KB (+0.06% 🔺)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs.production.min.js) 5.7 KB (0%)
2. entry point: @reduxjs/toolkit (without dependencies) (esm.js) 5.65 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs.production.min.js) 10 KB (+0.06% 🔺)
2. entry point: @reduxjs/toolkit/query (without dependencies) (esm.js) 10.42 KB (+0.06% 🔺)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs.production.min.js) 2.65 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (esm.js) 2.49 KB (0%)
3. createSlice (esm.js) 5.03 KB (0%)
3. createEntityAdapter (esm.js) 6.28 KB (0%)
3. configureStore (esm.js) 5.62 KB (0%)
3. createApi (esm.js) 17.08 KB (+0.13% 🔺)
3. createApi (react) (esm.js) 19.65 KB (+0.05% 🔺)
3. fetchBaseQuery (esm.js) 11.57 KB (0%)
3. setupListeners (esm.js) 10.39 KB (0%)
3. ApiProvider (esm.js) 18.49 KB (+0.06% 🔺)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5fecba:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
rtkq-beta-ssr-repro PR

@phryneas
Copy link
Member

phryneas commented Nov 9, 2021

I think this should do just fine. I'll give it another look in the evening just to be double sure.

@phryneas phryneas merged commit 907a948 into v1.7.0-integration Nov 12, 2021
@phryneas phryneas deleted the undefined-serializable branch November 12, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants