-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Port Redux's todos example #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is ready! Here's an easier to read diff that just includes my changes to Redux's original example and our readme: nickserv/redux-toolkit@86bf0b6...example |
Closed
It's unfortunate that this doesn't include any examples of |
Yeah, this PR is way stale. Thanks for starting it, @nickmccurdy , but we probably oughta just close it and restart from scratch. |
phryneas
added a commit
that referenced
this pull request
Nov 2, 2021
* start extracting ts-generation code * add csb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29.
I wanted to add an example both for documentation and dogfooding. I think todos is a great example because it's already used in many places including the basic Redux docs, this package's readme, reselect's readme, and Redux's automated tests.
I think we should do the async example next since it's also from the Redux docs and it leverages redux-thunk. The more similar we keep this to Redux's original examples, the easier it is for users to compare setup with this package and for us to potentially merge this back into Redux's examples.
Use FSA