Skip to content

Port Redux's todos example #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

Conversation

nickserv
Copy link
Collaborator

@nickserv nickserv commented Mar 6, 2018

Fixes #29.

I wanted to add an example both for documentation and dogfooding. I think todos is a great example because it's already used in many places including the basic Redux docs, this package's readme, reselect's readme, and Redux's automated tests.

I think we should do the async example next since it's also from the Redux docs and it leverages redux-thunk. The more similar we keep this to Redux's original examples, the easier it is for users to compare setup with this package and for us to potentially merge this back into Redux's examples.

  • Copy example from Redux to make a potential upstream merge easier
  • Use this package instead of using Redux directly
  • Use mutating reducers with immer
  • Use FSA
  • Use selectors
  • Keep usage consistent with readme (now it's based more on the original example)

@nickserv
Copy link
Collaborator Author

nickserv commented Mar 9, 2018

I think this is ready! Here's an easier to read diff that just includes my changes to Redux's original example and our readme: nickserv/redux-toolkit@86bf0b6...example

@nickserv nickserv changed the title WIP: Port Redux's todos example Port Redux's todos example Mar 9, 2018
@nickserv nickserv requested a review from hswolff March 17, 2018 01:27
@nickserv nickserv mentioned this pull request Apr 21, 2018
@nickserv nickserv removed the request for review from hswolff April 22, 2018 18:24
@spsaucier
Copy link

It's unfortunate that this doesn't include any examples of createSlice or createAction.

@markerikson
Copy link
Collaborator

Yeah, this PR is way stale. Thanks for starting it, @nickmccurdy , but we probably oughta just close it and restart from scratch.

phryneas added a commit that referenced this pull request Nov 2, 2021
* start extracting ts-generation code

* add csb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example
3 participants