Install Redux 4 and compatible versions of DevTools extension #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, what happens if we make Redux a peer dependency at 3 || 4 ? |
|
A breaking change. Redux would no longer be installed manually, so installing RSK will fail until Redux 3 or 4 is manually installed. I believe both would still satisfy peer dependencies, since redux-devtools-extension was updated for a bug fix which should be back compatible. |
|
This is a pretty straightforward change that is useful in other more opinionated PRs, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28, Redux 4 should now be fully supported. Tested by running
npm installwith no peer dependency warnings and successfully running the example (after updating React Redux).