Skip to content

Conversation

@aryaemami59
Copy link
Member

@aryaemami59 aryaemami59 commented Jan 25, 2024

This PR:

  • Migrates test configurations from Jest to Vitest in order to stay consistent with the rest of the redux packages.
  • Drop Jest related packages.
  • Drop React Native related tests.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c29ce2f:

Sandbox Source
Vanilla Typescript Configuration

@markerikson
Copy link
Contributor

FYI, I ran into issues here with the RN test when I was trying to update last year, which is why I stayed on Jest at that point. (At least now with v9 we've dropped the multiple aliased tests for React 17 and such that we had with v8.)

@aryaemami59 aryaemami59 marked this pull request as ready for review January 25, 2024 17:21
@timdorr
Copy link
Member

timdorr commented Jan 25, 2024

Since we're no longer testing RN, this makes a lot of sense. Plus, removing a net 3,315 lines (about 25%!) from the yarn.lock file is great!

I'll let @markerikson merge, since he's closer to this stuff than me. But LGTM!

@EskiMojo14 EskiMojo14 merged commit e450f2b into reduxjs:master Jan 27, 2024
@aryaemami59 aryaemami59 deleted the migrate-to-vitest branch January 28, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants