Skip to content

Integrate DefinitelyTyped TypeScript types into the project #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
severen opened this issue Feb 16, 2018 · 6 comments
Closed

Integrate DefinitelyTyped TypeScript types into the project #880

severen opened this issue Feb 16, 2018 · 6 comments

Comments

@severen
Copy link

severen commented Feb 16, 2018

Redux itself currently ships with TypeScript types bundled, yet this does not. It seems like it would make sense to me to also ship types in this repository, especially as react-redux and redux are tightly integrated.

I ended up thinking about this due to the fact that using @types/react-redux with the latest beta releases of Redux (which have overhauled type definitions that fix an issue I was having) requires me going into the node_modules folder and manually deleting its dependency on Redux 3.x so that everything works how it should. If this project included the definitions like Redux does, both projects could then have matching beta/@next releases, which would fix this issue.

@stereobooster
Copy link

Maybe make redux a peerDependency?

@ericanderson
Copy link
Contributor

Could you not just map in your own types for a pre release?

@aikoven
Copy link

aikoven commented Feb 20, 2018

See discussion in #815

@timdorr timdorr closed this as completed Feb 20, 2018
@stereobooster
Copy link

@aikoven what about making redux a peerDependency? So I can use latest redux with react-redux

@aikoven
Copy link

aikoven commented Feb 20, 2018

@stereobooster Isn't it a peer already? package.json#L50

@stereobooster
Copy link

Yes indeed, then my issue is due to some other cause. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants