-
Notifications
You must be signed in to change notification settings - Fork 47
Clarify the K8s compatibility guidelines #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis change updates documentation related to Kubernetes compatibility for Redpanda. The Changes
Assessment against linked issues
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
modules/upgrade/pages/k-compatibility.adoc (1)
28-36: Reduce duplication in the "Kubernetes version policy" sectionThe sentence in line 32 repeats the content of the footnote. Consider referencing
{fn-k8s-compatibility}to keep the text DRY:- The Kubernetes versions listed in the compatibility matrix are suggested ranges, based on testing and reported usage. Not every patch or minor version within these ranges is explicitly tested. + See {fn-k8s-compatibility} for details on the suggested Kubernetes version ranges based on testing and reported usage.This ensures consistency if the footnote text changes in the future.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
antora.yml(1 hunks)modules/upgrade/pages/k-compatibility.adoc(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (4)
antora.yml (1)
34-34: Verify the Kubernetes version bump aligns with compatibility policyThe
supported-kubernetes-versionwas updated from1.25.0-0to1.27.0-0. Confirm this matches the minimum version defined ink-compatibility.adocand that metadata acrossantora.ymland the documentation are in sync.modules/upgrade/pages/k-compatibility.adoc (3)
24-24: Approve EoL phrasing update for Operator and Helm chartThe reworded note on EoL support for Operator and Helm chart is clear and consistent. Good improvement.
56-56: Verify footnote rendering in the compatibility matrixYou added
{fn-k8s-compatibility}to the Kubernetes range for Redpanda Core 25.1.x. Ensure the attribute is correctly defined (line 4) and that the footnote marker renders properly in all output formats.
79-84: Approve refined Console integration descriptionThe updated paragraphs on Redpanda Console integration are concise and clarify the subchart and version dependency. This enhances reader clarity on how Helm chart upgrades impact Console versions.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
asimms41
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| |25.1.1-beta1, 2.4.x, 2.3.x | ||
| |3.12+ | ||
| |1.29.x - 1.32.x | ||
| |1.28.x - 1.32.x{fn-k8s-compatibility} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also do the same for the rows below on K8s? We could also move the footnote to outside the table but leave the reference i.e. [1] here.
david-yu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thank you!
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-1262
Review deadline: April 30
This pull request updates Kubernetes compatibility information and refines documentation around Redpanda Console integration. The changes include updating the supported Kubernetes version, adding a Kubernetes version policy section, and simplifying the description of Redpanda Console deployment.
Kubernetes compatibility updates:
supported-kubernetes-versioninantora.ymlto1.27.0-0.k-compatibility.adoc.k-compatibility.adoc, detailing the minimum supported version and compatibility testing process.1.28.x - 1.32.x).Redpanda Console documentation refinements:
k-compatibility.adoc.Page previews
https://deploy-preview-1094--redpanda-docs-preview.netlify.app/current/upgrade/k-compatibility/
Checks
Summary by CodeRabbit