Skip to content

Skip echo call for RedisCluster mode #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

Skip echo call for RedisCluster mode #344

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d69ed1
echo is not available for RedisCluster mode hence skipping the echo i…
NishithHM May 30, 2025
765445e
updated for method validate_async_redis and changed condtion to hasattr
NishithHM Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion redisvl/redis/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,9 @@ def validate_sync_redis(
redis_client.client_setinfo("LIB-NAME", _lib_name)
except ResponseError:
# Fall back to a simple log echo
redis_client.echo(_lib_name)
# For RedisCluster, echo is not available
if hasattr(redis_client, "echo"):
await redis_client.echo(_lib_name)

# Get list of modules
installed_modules = RedisConnectionFactory.get_modules(redis_client)
Expand All @@ -423,6 +425,8 @@ async def validate_async_redis(
except ResponseError:
# Fall back to a simple log echo
await redis_client.echo(_lib_name)
if hasattr(redis_client, "echo"):
await redis_client.echo(_lib_name)

# Get list of modules
installed_modules = await RedisConnectionFactory.get_modules_async(redis_client)
Expand Down
Loading