clientlist response, client_name value might contain the '=' character, in that case response parser will fail #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laixintao
approved these changes
Sep 21, 2017
…r, in that case the response parser will fail
|
@laixintao |
laixintao
approved these changes
Sep 22, 2017
|
looks good to me! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate
127.0.0.1:6379> CLIENT SETNAME roi=lipman
OK
127.0.0.1:6379> CLIENT LIST
id=2 addr=127.0.0.1:49481 fd=8 name=roi=lipman age=27 ...
redis-py
File "/opt/redislabs/lib/cnm/python/redis/client.py", line 609, in client_list
File "/opt/redislabs/lib/cnm/python/redis/client.py", line 574, in execute_command
File "/opt/redislabs/lib/cnm/python/redis/client.py", line 588, in parse_response
File "/opt/redislabs/lib/cnm/python/redis/client.py", line 248, in parse_client_list
ValueError: dictionary update sequence element #3 has length 3; 2 is required
This PR splits on '=' only once,
such that client_name key will be "name" and the value would be "roi=lipman".