Adding e2e scenario tests for maintenance push notifications handling. #3758
Conversation
petyaslavova
force-pushed
the
ps_hitless_add_e2e_tests
branch
4 times, most recently
from
98d13c8 to
394c020
Compare
…ons - second try + some test helpers improvements
petyaslavova
force-pushed
the
ps_hitless_add_e2e_tests
branch
from
394c020 to
eaeedc1
Compare
| tuple: (target_node, empty_node) where target_node has master shards | ||
| and empty_node has no shards | ||
| """ | ||
| cluster_info = ClusterOperations.get_cluster_nodes_info( |
There was a problem hiding this comment.
Is there's a specific reason why you decided to use rladmin and not the REST API here? There's v1/shards endpoint that returns you information about shards so you can easier find the node with master shards and nodes without shards.
rladmin is more an internal tool, whereas REST API is public so I would suggest to use it for this purposes. Since, rladmin is a plain text we might encounter parsing issues if it will be changed whereas REST API returns standardised JSON object
https://redis.io/docs/latest/operate/rs/references/rest-api/requests/shards/#example-json-body
There was a problem hiding this comment.
No specific reason.
We were using this for our testing for a long time + the demo, so thats why we stuck to that as we know it worked.
The API requests were less explored.
I am ok to switch to that approach instead, although it will take some time to refactor the code.
| endpoint_id: str, | ||
| ) -> str: | ||
| """Execute rladmin bind endpoint command and wait for completion.""" | ||
| command = f"bind endpoint {endpoint_id} policy single" |
There was a problem hiding this comment.
The same achievable with REST API
curl -X PUT \
-H "accept: application/json" \
-H "Content-Type: application/json" \
-u "[username]:[password]" \
https://[host]:9443/v1/bdbs/[database_id] \
-d '{
"proxy_policy": "all-master-shards",
"endpoint_ip": "[specific_ip]",
"port": [port_number]
}' \
-k -i
| empty_node: str, | ||
| ) -> str: | ||
| """Execute rladmin migrate command and wait for completion.""" | ||
| command = f"migrate node {target_node} all_shards target_node {empty_node}" |
There was a problem hiding this comment.
Same achievable with REST API
curl -X POST \
-H "accept: application/json" \
-H "Content-Type: application/json" \
-u "[username]:[password]" \
https://[host]:9443/v1/shards/actions/migrate \
-d '{
"shard_uids": ["2","4","6"],
"target_node_uid": 9,
"override_rack_policy": false,
"preserve_roles": false,
"max_concurrent_bdb_migrations": 3
}' \
-k -i
961ebce to
015550b
Compare
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.