Skip to content

Add support for ModuleCommands in cluster #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add support for ModuleCommands in cluster #2951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions redis/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,10 @@ class AbstractRedisCluster:
"LATENCY HISTORY",
"LATENCY LATEST",
"LATENCY RESET",
"MODULE LIST",
"MODULE LOAD",
"MODULE UNLOAD",
"MODULE LOADEX",
],
DEFAULT_NODE,
),
Expand Down
4 changes: 4 additions & 0 deletions redis/commands/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,13 @@
AsyncFunctionCommands,
AsyncGearsCommands,
AsyncManagementCommands,
AsyncModuleCommands,
AsyncScriptCommands,
DataAccessCommands,
FunctionCommands,
GearsCommands,
ManagementCommands,
ModuleCommands,
PubSubCommands,
ResponseT,
ScriptCommands,
Expand Down Expand Up @@ -873,6 +875,7 @@ class RedisClusterCommands(
ScriptCommands,
FunctionCommands,
GearsCommands,
ModuleCommands,
RedisModuleCommands,
):
"""
Expand Down Expand Up @@ -903,6 +906,7 @@ class AsyncRedisClusterCommands(
AsyncScriptCommands,
AsyncFunctionCommands,
AsyncGearsCommands,
AsyncModuleCommands,
):
"""
A class for all Redis Cluster commands
Expand Down
1 change: 0 additions & 1 deletion tests/test_asyncio/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3213,7 +3213,6 @@ async def test_memory_usage(self, r: redis.Redis):
assert isinstance(await r.memory_usage("foo"), int)

@skip_if_server_version_lt("4.0.0")
@pytest.mark.onlynoncluster
async def test_module_list(self, r: redis.Redis):
assert isinstance(await r.module_list(), list)
for x in await r.module_list():
Expand Down
1 change: 0 additions & 1 deletion tests/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4909,7 +4909,6 @@ def test_latency_latest(self, r: redis.Redis):
def test_latency_reset(self, r: redis.Redis):
assert r.latency_reset() == 0

@pytest.mark.onlynoncluster
@skip_if_server_version_lt("4.0.0")
@skip_if_redis_enterprise()
def test_module_list(self, r):
Expand Down