Skip to content

Avoid reference cycling by the garbage collector during response reading #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Avoid reference cycling by the garbage collector during response reading #2932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion redis/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,10 @@ def read_response(
self.next_health_check = time() + self.health_check_interval

if isinstance(response, ResponseError):
raise response
try:
raise response
finally:
del response # avoid creating ref cycles
return response

def pack_command(self, *args):
Expand Down