Skip to content

Change SISMEMBER return type to int #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Change SISMEMBER return type to int #2813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fb2eee
change sismember return type
dvora-h Jun 27, 2023
0b24604
Merge branch '5.0' into fix-sismember
dvora-h Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion redis/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ class AbstractRedis:
# **string_keys_to_dict(
# "COPY "
# "HEXISTS HMSET MOVE MSETNX PERSIST "
# "PSETEX RENAMENX SISMEMBER SMOVE SETEX SETNX",
# "PSETEX RENAMENX SMOVE SETEX SETNX",
# bool,
# ),
# **string_keys_to_dict(
Expand Down
8 changes: 6 additions & 2 deletions redis/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3339,9 +3339,13 @@ def sinterstore(
args = list_or_args(keys, args)
return self.execute_command("SINTERSTORE", dest, *args)

def sismember(self, name: str, value: str) -> Union[Awaitable[bool], bool]:
def sismember(
self, name: str, value: str
) -> Union[Awaitable[Union[Literal[0], Literal[1]]], Union[Literal[0], Literal[1]]]:
"""
Return a boolean indicating if ``value`` is a member of set ``name``
Return whether ``value`` is a member of set ``name``:
- 1 if the value is a member of the set.
- 0 if the value is not a member of the set or if key does not exist.

For more information see https://redis.io/commands/sismember
"""
Expand Down