Importing redis_om can unexpectedly alter environment variables

[aberres]

In redis_om/connections.py we find a call to dotenv.load_dotenv() which is executed at import time. IMHO a library should never do such things - at least not silently.

As an application developer, it is my responsibility ensure that all environment variables are read from whatever config I prefer. If I want to use dotenv to setup variables, it should be my job to do so.

[raceychan]

agree

[simonprickett]

First up sorry for the slow reply here... I took a look at this and usage of dotenv seems to be minimal, and I'm pretty sure that it's just REDIS_OM_URL. I think this would be safe to remove in a future release.

Usages of dotenv: https://github.com/redis/redis-om-python/search?q=dotenv

There's also no .env file in the repo and the tests don't seem to depend on one as REDIS_OM_URL is set as needed in Makefile.

[simonprickett]

Fixed in 0.0.24 release.