Skip to content

fixed the load-stream bechmarks such that the memory footprint does not keep growing. #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2023
Merged

fixed the load-stream bechmarks such that the memory footprint does not keep growing. #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55ae308
fixed the load-stream bechmarks such that the memory footprint does n…
slice4e Feb 1, 2023
cd74aed
formatting using poetry run black
slice4e Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions redis_benchmarks_specification/__runner__/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,12 @@ def process_self_contained_coordinator_stream(

if args.benchmark_local_install:
logging.info("Running memtier benchmark outside of docker")
benchmark_command_str = "taskset -c " + client_cpuset_cpus + " " + benchmark_command_str
benchmark_command_str = (
"taskset -c "
+ client_cpuset_cpus
+ " "
+ benchmark_command_str
)
logging.info(
"Running memtier benchmark command {}".format(
benchmark_command_str
Expand Down Expand Up @@ -1037,7 +1042,9 @@ def data_prepopulation_step(
if benchmark_local_install:
logging.info("Running memtier benchmark outside of docker")

preload_command_str = "taskset -c " + client_cpuset_cpus + " " + preload_command_str
preload_command_str = (
"taskset -c " + client_cpuset_cpus + " " + preload_command_str
)
logging.info(
"Pre-loading using memtier benchmark command {}".format(
preload_command_str
Expand Down
4 changes: 2 additions & 2 deletions ...est-suites/memtier_benchmark-1Mkeys-load-stream-1-fields-with-100B-values-pipeline-10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dbconfig:
keyspacelen: 0
resources:
requests:
memory: 12g
memory: 5g
tested-commands:
- xadd
redis-topologies:
Expand All @@ -18,7 +18,7 @@ build-variants:
clientconfig:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
arguments: '"--pipeline" "10" "--data-size" "100" --command "XADD __key__ * field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
arguments: '"--pipeline" "10" "--data-size" "100" --command "XADD __key__ MAXLEN ~ 1 * field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
resources:
requests:
cpus: '4'
Expand Down
4 changes: 2 additions & 2 deletions ...cification/test-suites/memtier_benchmark-1Mkeys-load-stream-1-fields-with-100B-values.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dbconfig:
keyspacelen: 0
resources:
requests:
memory: 1g
memory: 5g
tested-commands:
- xadd
redis-topologies:
Expand All @@ -18,7 +18,7 @@ build-variants:
clientconfig:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
arguments: '"--data-size" "100" --command "XADD __key__ * field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
arguments: '"--data-size" "100" --command "XADD __key__ MAXLEN ~ 1 * field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
resources:
requests:
cpus: '4'
Expand Down
4 changes: 2 additions & 2 deletions ...est-suites/memtier_benchmark-1Mkeys-load-stream-5-fields-with-100B-values-pipeline-10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dbconfig:
keyspacelen: 0
resources:
requests:
memory: 35g
memory: 8g
tested-commands:
- xadd
redis-topologies:
Expand All @@ -18,7 +18,7 @@ build-variants:
clientconfig:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
arguments: '"--pipeline" "10" "--data-size" "100" --command "XADD __key__ * field __data__ field __data__ field __data__ field __data__ field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
arguments: '"--pipeline" "10" "--data-size" "100" --command "XADD __key__ MAXLEN ~ 5 * field __data__ field __data__ field __data__ field __data__ field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
resources:
requests:
cpus: '4'
Expand Down
4 changes: 2 additions & 2 deletions ...cification/test-suites/memtier_benchmark-1Mkeys-load-stream-5-fields-with-100B-values.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dbconfig:
keyspacelen: 0
resources:
requests:
memory: 35g
memory: 8g
tested-commands:
- xadd
redis-topologies:
Expand All @@ -18,7 +18,7 @@ build-variants:
clientconfig:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
arguments: '"--data-size" "100" --command "XADD __key__ * field __data__ field __data__ field __data__ field __data__ field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
arguments: '"--data-size" "100" --command "XADD __key__ MAXLEN ~ 5 * field __data__ field __data__ field __data__ field __data__ field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
resources:
requests:
cpus: '4'
Expand Down