-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Main #3047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Main #3047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the package-lock.json from the PR
Done! The package-lock.json file has been removed. |
Hi @watersRand, i can still see the package-lock.json being in the diff. Did you add it again? |
Please @nkaradzhov guide me on the issue .I have both removed and added the package-json yet still issues were raised |
@watersRand the package-lock.json file should not be part of the PR. I asked you to remove it. You removed it, and then introduced it again. ![]() I dont know how better to articulate this. |
removed the package-lock.json |
@watersRand it looks like the package-lock.json is still in the diff of the PR: Just to say it again, your PR changes should consist of only the |
#corrected issues raised by maintainer
#rolled back latency histogram